WIP: Optimized matcher #3707
Closed
WIP: Optimized matcher #3707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1) error handling async component errors
Message:
Expected spy warn to have been called once. It was called 0 times.
Stack:
Error: Expected spy warn to have been called once. It was called 0 times.
at /home/iurisilvio/code/oss/vue-router/test/unit/specs/error-handling.spec.js:157:30
at <anonymous>
at processTicksAndRejections (internal/process/task_queues.js:95:5)
|
✔️ Deploy Preview for vue-router-docs-v3 canceled. 🔨 Explore the source changes: 7b4b084 🔍 Inspect the deploy log: https://app.netlify.com/sites/vue-router-docs-v3/deploys/61f6f32903b198000767f58d |
It is handled as dynamic route.
This reverts commit bc46fa8.
This was referenced Jan 30, 2022
|
I did a small benchmark script to prove the concept, in my own machine. https://gist.github.com/iurisilvio/a916ce2de16336ec97aab8db5525f7f9 For 100 static routes, current vue-router takes 14ms average to resolve and my version takes less than 1ms. Even to resolve the first result, it is 30% slower because it evaluates one regex. |
|
For dynamic paths, it will evaluate only part of the routes, based on first level path. If you have 100 rules but only 5 starting with the same first level path, it will evaluate at most 5 rules. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft implementation with some new ideas.
Regex match is 10x slower than simple object access. I still have to run some dynamic matches to not break ordering compatibility.
I still want to integrate it better with current code, I did this implementation to validate the issue and run some benchmarks.